feat: Add elemental fractions to material recording#5270
feat: Add elemental fractions to material recording#527056laurenwills wants to merge 1 commit intoacts-project:mainfrom
Conversation
Extend material recording to include all elements and their fraction seen at a material interaction. Include a toggle to enable or disable this feature. Extend the BinnedSurfaceMaterial class to include this information in material mapping. This information is needed for detailed material composition studies and to make the material description compatible with Geant4.
56laurenwills
changed the title
github-actions
bot
added
Component - Core
| std::shared_ptr<Algorithm::Config>>(alg, "Config") | ||
| .def(py::init<>()); | ||
| ACTS_PYTHON_STRUCT(c, outputMaterialTracks, excludeMaterials); | ||
| ACTS_PYTHON_STRUCT(c, outputMaterialTracks, excludeMaterials, DetailedMaterial); |
There was a problem hiding this comment.
We are using CamelCase, in this case it needs to be "detailMaterial", however, I would even make it more explicit: "recordElementFactions".
| std::shared_ptr<EventStore> eventStore; | ||
|
|
||
| std::vector<std::string> excludeMaterials = {}; | ||
| bool DetailedMaterial = false; |
There was a problem hiding this comment.
See my comment "this should be more explicit & it should start with a small letter".
| MappingType mappingType = MappingType::Default); | ||
| MappingType mappingType = MappingType::Default, | ||
| ElementZMatrix elementZ = {}, | ||
| ElementFracMatrix elementFrac = {}); |
There was a problem hiding this comment.
We should discuss this, I think a better way to think about it is to have this part of the MaterialSlab (optional).
|
Great to see this moving forward!!! I have the following suggestion:
|
2 participants
Extend material recording to include all elements and their fraction seen at a material interaction. Include a toggle to enable or disable this feature. Extend the BinnedSurfaceMaterial class to include this information in material mapping. This information is needed for detailed material composition studies and to make the material description compatible with Geant4.
--- END COMMIT MESSAGE ---
@noemina - tagging for review